Repository navigation
List every earlier reader-source starter as an upgrade baseline - #14
Merged
Merged
Conversation
Pack beta.4 named only the beta.3 reader-source starter as `upgrade_from`, so a collection holding an earlier starter was merged against the wrong document. mdbase-spec 05A (mdbase-dev/mdbase-spec#59) lets a seed list every starter it supports, and engines choose the baseline from the lock's seed origin. Pack beta.5 lists the same baselines as Reader's pack beta.5, byte for byte and under the same paths, newest first with their `version`: Reader's beta.3 starter (82869c1, Writer's beta.3), beta.2 (54f46e7) and beta.1 (e8a3fca, Writer's beta.1 and beta.2). The existing byte-identity test now covers every listed baseline against Reader's copies. Until a Connect release includes mdbase-dev/mdbase-connect#567, @mdbase-dev/connect-dev rejects baseline lists, so connect-protocol 0.1.0-beta.124 is patched with that PR's schema change. Drop the patch when moving to that release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready: Connect beta125, which includes mdbase-dev/mdbase-connect#567, is in production, and the SDK is published at 0.1.0-beta.125.
What changes
Pack
dev.mdbase.writer1.0.0-beta.5 ships the same starters as beta.4. Thereader-sourceseed'supgrade_fromnow lists the same baselines as Reader's pack beta.5 (mdbase-dev/mdbase-reader#59), byte-identical and at the same paths, newest first, each withversion: 1:mdbase/baselines/1.0.0-beta.3/types/reader-source.md82869c12…mdbase/baselines/1.0.0-beta.2/types/reader-source.md(new)54f46e7c…mdbase/baselines/1.0.0-beta.1/types/reader-source.md(new)e8a3fca6…Baseline directories are named for the Reader pack version that first shipped each starter.
Tests
mdbase-readeris a sibling checkout.sha256:21dfd856…), and the released beta.4 pin is reproduced from the listed beta.3 baseline. Both digests matchmdbase packs assess(Rust CLI at mdbase-rs 056db73).pnpm typecheckandpnpm testpass locally. Writer has no CI.CLI: an unedited Writer beta.3 or beta.4 collection upgrades to beta.5 (reader-source replaced with the exact v2 bytes,
upgrade_baseline= beta.3). The reader-source seed of Writer beta.1/beta.2 is planned as anupdatefrom the beta.1 baseline, but those upgrades still fail to apply. The cause is older: the preservedwriter-manuscriptseed requires manuscript contract 1.0.0-beta.1. The upgrade to the released beta.4 fails the same way, and this PR doesn't change it.Dependencies
The
@mdbase-dev/connect*packages are pinned to 0.1.0-beta.125, whose manifest schema accepts the list form. The temporary connect-protocol patch that backported it is removed.