Verify every pack through mdbase-ts 0.3.0-rc.8 as well as the Rust CLI - #15
Merged
Merged
Conversation
Pin CI's mdbase-ts checkout to tag v0.3.0-rc.8, which supports seed upgrade_from, and run npm test once per engine in a matrix. Route all pack installs (verify, People and TaskNotes tests) through one engine selector so the TaskNotes upgrade and plugin-collection tests no longer skip without the CLI. Use rc.8's v0.3 update member patch in the People pack test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI built mdbase-ts from an old pinned commit but also set
MDBASE_VERIFY_CLI, so every pack install actually ran through the Rust CLI only. That older mdbase-ts rejected seedupgrade_from("must NOT have additional properties"), which tasknotes.task, mdbase.contact 1.3.0, mdbase.comment 1.0.1 and mdbase.view 1.0.1 now use. mdbase-ts 0.3.0-rc.8 supportsupgrade_fromwith the Rust engine's semantics, so CI can now verify every pack through both engines.What
sources.json:typescript_implementation.refis now the tagv0.3.0-rc.8. This git checkout is the single source of truth for the mdbase-ts version; the npm package is not used.seed_upgrade_cliis renamed torust_cli, since the CLI is no longer there only to work around missing seed upgrades.engine: [mdbase-ts, mdbase-cli]runsnpm testonce per engine. Only the CLI leg builds the Rust CLI and setsMDBASE_VERIFY_CLI. The comment about mdbase-ts being unable to run seed upgrades is removed.scripts/pack-engine.mjs: one loader for mdbase-ts and onepackEngine()that installs through either engine, with adoptions supported in both.verify.mjs,person-pack.test.mjsand the two TaskNotes tests all use it. The TaskNotes upgrade and plugin-collection tests used to skip without the CLI (33 skipped). They now run through mdbase-ts as well.person-pack.test.mjs: usespatchfor updates. rc.8 rejects the oldfieldsalias.withLegacyResourceModesstays. Both rc.8 and the CLI still reject the immutable mdbase.contact 1.0.0 provision, which has nomode.Verification
Local, with mdbase-ts built from tag v0.3.0-rc.8:
MDBASE_TS_DIR=<rc.8> npm test: "Verified 24 contract and 12 pack installs with mdbase-ts"; node tests 27/27 and 42/42 pass, 0 skipped.MDBASE_VERIFY_CLI=<mdbase 0.1.0-beta.123> MDBASE_TS_DIR=<rc.8> npm test: "... with mdbase CLI"; 27/27 and 42/42 pass, 0 skipped.