Repository navigation
next: private device enrol returns the log URL and genesis item - #631
Merged
Merged
Conversation
…item A joining device must pin the collection's genesis (sync.json genesis_hash) before trusting the log; the answer now returns the exact appended seq-1 bytes (candidate bytes the device verifies against its trust pins), as create does.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 6, 2026
Contributor
Author
|
security (post-merge): no blocking findings — security on merged head 6ac1fd4 (merge 7091725), scope: private device enrol response now carries log_url and the exact appended seq-1 genesis item (same change as #630 for cloud-copy join). The server only echoes the appended batch it already holds (appendedBatch requires the appended state), under the same proof/current-identity checks as before; the enrolling device must still verify and pin the genesis against the log and its trusted roots (replica genesis pin, c3b0da99/825e0954), so a wrong or forged genesis from the control plane is a terminal mismatch for that collection, not a trust widening. No new authority, secret or route. Ledger row added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #630, which is queued. It applies the same change to
POST /v1/next/collections/:id/private/devices: the answer also carrieslog_urlandgenesis: {seq: 1, item}, the exact appended seq-1 bytes. The enrolling device verifies and pins them before it trusts the log.