Repository navigation
Read baseline identity without alias expansion so anchored starters validate - #574
Merged
Merged
Conversation
…alidate
typeFrontmatter (protocol manifest validation) and declaredTypeVersion
(devkit) converted the whole baseline frontmatter with toJS({ maxAliasCount:
0 }), which throws on any YAML alias. TaskNotes' first task starter reuses an
enum through `&a1`, so its rc.17 and rc.18 manifests failed validation. Both
only need the top-level kind, name and version: read those with
Document.get, keeping alias expansion disabled.
This was referenced Oct 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while preparing TaskNotes for baseline lists (#567):
validateAppManifestthrowsReferenceError: Alias resolution is disabledfor TaskNotes'tasknotes.taskmanifests — both the rc.17 one on TaskNotes main and the new rc.18 one — because its first task starter reuses an enum through a YAML anchor (&a1).typeFrontmatter(packages/protocol/src/manifest.ts) anddeclaredTypeVersion(packages/devkit) converted the whole baseline frontmatter withtoJS({ maxAliasCount: 0 }). Both only need the top-levelkind,nameandversion; they now read those withDocument.get, so anchors elsewhere are harmless and alias expansion stays disabled.seed upgrade baselines may use YAML anchors without alias expansion(valid, and a wrongversionis still caught); devkit derivesversionfrom an anchored starter. Protocol 78/78, devkit 15/15.check:architecture(no growth) andcheck:changelogpass. Must merge before beta.125 is cut.