Repository navigation
Accept the recovery worker's projection when it supersedes the test driver - #568
Merged
Merged
Conversation
…river writes_with_a_current_projection_reject_duplicate_unique_values installs a type pack, which schedules recovery; its projection worker can supersede or lease the generation the test drives. The driver retried only provider_database_retryable, so CI failed with projection_generation_not_building, including on PRs that change nothing here (e.g. #502). Handle the hand-off as the provider's own bootstrap does: accept a projection the worker made current, otherwise start a fresh generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System suite (files-adversarial)fails on unrelated PRs (e.g. #502 on the current engine pin, and #567) with:The test installs a type pack, which schedules recovery; the recovery projection worker races the test's own projection driver and can supersede or lease its generation.
complete_projectionretried onlyprovider_database_retryable.Fix (test-only): treat
projection_generation_not_building/projection_lease_unavailableas a hand-off, exactly as the provider's own bootstrap does (provider/collections.rs): if the worker made the projection current, accept it; otherwise start a fresh generation (bounded).Evidence: bisected the test against a disposable loopback PostgreSQL across mdbase-rs 47890a9 → 618b1f8 → ff5d77b → 056db73: it passes locally at every revision (alone and as the whole binary,
--test-threads=1), and fails in CI on PRs with and without engine changes — a CI-timing race, not a regression. With this change the wholehosted_write_validationbinary passes locally (5/5); clippy clean.