Skip to content

Share private feedback across mdbase applications - #558

Merged
callumalpass merged 3 commits into
mainfrom
feat/shared-feedback
Oct 2, 2026
Merged

callumalpass merged 3 commits into
mainfrom
feat/shared-feedback

Conversation

@callumalpass

Copy link
Copy Markdown
Contributor

Summary

  • Replace Connect feedback with a shared form-first flow for Editor, Connect, Reader and Writer.
  • Add explicit screenshot capture/redaction, consent-only diagnostics, three feedback topics and a bounded error-responsive bug.
  • Extend the stateless Worker to schema v2 while retaining deployed v1 clients.
  • Keep the simplified copy, private delivery and initial bundle budgets.

Verification

Previous implementation: UI, Worker, Editor unit/browser tests, typechecks/builds, CSP/bundle/architecture checks, real Chromium capture and positive control passed. Integrated current main including mark motion and startup cancellation; full local CI is running, with results to follow.

Rollout

No deployment or publication is included. Deploy the compatible Worker before schema-v2 browser clients through guarded cloud-ops. Reader/Writer source integrations are prepared separately and cannot merge until a coordinated UI package publication and dependency update.

@callumalpass
callumalpass enabled auto-merge October 2, 2026 12:04
@callumalpass
callumalpass added this pull request to the merge queue Oct 2, 2026
@callumalpass
callumalpass removed this pull request from the merge queue due to a manual request Oct 2, 2026
@callumalpass
callumalpass added this pull request to the merge queue Oct 2, 2026
@callumalpass

Copy link
Copy Markdown
Contributor Author

Verification update: full local pnpm ci:local passed (Node and Rust tiers, including clippy and workspace tests) against current main and the pinned engine checkout. Windows CI exposed a case-insensitive emit collision between Feedback.tsx and feedback.ts; fixed by renaming the internal helper to feedback-data.ts, adding a source-stem regression and a general tarball path-collision guard. Shared UI now has 50 passing tests; Editor typecheck, package audit and architecture rechecked. Exact revised Windows and macOS Intel regression jobs, Editor CI and required PR Qualification have passed. No production publication or deployment performed. Reader/Writer integrations are being verified separately with generated local UI links and will remain release-blocked drafts until an actual package is published.

@callumalpass

Copy link
Copy Markdown
Contributor Author

Consumer integrations are prepared and locally verified as release-blocked drafts: Reader mdbase-dev/mdbase-reader#52 and Writer mdbase-dev/mdbase-writer#8. No dependency masquerades as a published release. Full local CI and the isolated local MVP end-to-end path passed; the latter was rerun under Node 24.

First merge-queue attempt: files failed before tests on a Docker Hub HTTP 500; desktop timed out waiting for the pairing/restart status. Other lanes passed, including Windows core. Attempt 2 reruns those two failed jobs only, retaining exact commit/gates; no waiver or bypass. Both consumer desktop/mobile feedback acceptance runs intercept every POST (no inbox delivery), and temporary previews are stopped.

Merged via the queue into main with commit ef35e45 Oct 2, 2026
27 checks passed
@callumalpass
callumalpass deleted the feat/shared-feedback branch October 2, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant