Repository navigation
Let canonical views page while the projection is rebuilt - #499
Merged
Merged
Conversation
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 28, 2026
A definition change retires the active semantic generation until the recovery worker rebuilds it. Direct queries and Base views page without a pinned generation in that window, and validate_generation_binding already accepts an unpinned canonical view, but hosted_provider_query_cursors_check3 still required one for canonical_view cursors. The first paged execute_view after any definition change failed with provider_internal_error. Every request kind now permits an unpinned generation, so the constraint is dropped rather than widened. The new lifecycle test pages a canonical view straight after create_type; it fails without the migration.
The consolidated beta69 upgrade test and the final-rollback preflight fixture pin the current migration endpoint; the canonical-view rebuild test installs the mdbase.view contract now that views are identified through it.
callumalpass
force-pushed
the
fix/hosted-canonical-view-generation
branch
from
September 28, 2026 18:42
a7a6fe0 to
5ff16e7
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Sep 28, 2026
callumalpass
enabled auto-merge
September 28, 2026 18:42
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A definition change retires the active semantic generation until the recovery worker rebuilds it. Direct queries and Obsidian Base views page without a pinned generation in that window, and
validate_generation_bindingalready accepts an unpinned canonical view, buthosted_provider_query_cursors_check3still required a generation forcanonical_viewcursors. The first pagedexecute_viewafter any definition change (create_type,apply_type_pack, …) therefore failed withprovider_internal_error.Migration 0044 drops the constraint: with canonical views admitted, every request kind permits an unpinned generation, so widening it would leave a check that restricts nothing.
New Postgres lifecycle test
canonical_views_execute_while_the_projection_is_rebuiltpages a canonical view straight aftercreate_type; it fails without the migration. The migration-inventory test moves to 44.Found while running views after installing the
mdbase.viewpack (#498); independent of that change.Verification:
pnpm ci:localpasses (after repairing a broken Electron install in the fresh worktree), plus both Postgres tests.🤖 Generated with Claude Code