compat.glfw: declare abi:glibc capability (linux)#33
Merged
Conversation
Lets mcpp enforce that GLFW consumers use a glibc toolchain (it links the glibc X11/GL world); musl-static now fails fast with an actionable ABI error instead of a cryptic arc4random_buf failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
abi:glibcto compat.glfw's linux runtime capabilities so mcpp can enforce ABI compatibility (musl-static fails fast with an actionable message rather than a deep arc4random_buf error). Surfaced bymcpp why/mcpp doctor. Pairs with mcpp-community/mcpp#109 (capability-driven ABI enforcement).