fix: support .ccm/.cxxm/.ixx module interface extensions#272
Open
ZheFeng7110 wants to merge 2 commits into
Open
fix: support .ccm/.cxxm/.ixx module interface extensions#272ZheFeng7110 wants to merge 2 commits into
ZheFeng7110 wants to merge 2 commits into
Conversation
Member
|
这几个后缀比较小众, 先保留PR 后面看是否有很多相关项目真实使用 到时候 再评估是否再合入, 目前先以推荐 cppm / cpp 为推荐 看是否可以形成共识 简化表达 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan.cppmhardcoded.cppmextension checks, causing non-.cppmmodule interface files (.ccm,.cxxm,.ixx) to have their object files excluded from link units, resulting in "module not found" linker errors.Changes
src/build/plan.cppm: Link object collection now usescu.providesModulesemantic check instead of extension check;object_filename_fortreats all 4 module extensions equally with.mprefixsrc/build/execute.cppm: Freshness check now recognizes.ccm/.cxxm/.ixxtests/unit/test_module_extensions.cpp(new): Unit tests forobject_filename_fordisambiguationtests/e2e/152_module_extensions.sh(new): End-to-end build→link→run test for all 4 extensionsTest plan
mcpp buildself-host passes