feat: add highlighted-lines chip, collapsible windows, icon CSS variables#33
Open
mcanouil wants to merge 3 commits into
Open
feat: add highlighted-lines chip, collapsible windows, icon CSS variables#33mcanouil wants to merge 3 commits into
mcanouil wants to merge 3 commits into
Conversation
Update @module annotation style (bare name to quoted name) across html, logging, metadata, pandoc-helpers, and string modules to match the canonical versions in creating-quarto-extension/assets/modules.
…bles Render Quarto's code-line-numbers spec (or a new code-window-lines attribute) as a chip beside the filename in the code-window title bar, across HTML, Reveal.js, and Typst. The chip is toggled globally via the lines-label option. Wrap code windows in a <details> element on HTML and Reveal.js when the new code-window-collapse attribute is set on a block, or document-wide via the collapse option. The title bar becomes the <summary>. Expose --code-window-macos-icon, --code-window-windows-icon, matching icon width variables, and a shared icon height variable, so users can override the window-button SVGs from their own stylesheet without forking the extension. Update example.qmd, README, schema, and CHANGELOG accordingly.
Extract resolve_collapse helper shared by the per-block attribute reader and the document-level option parser. Collapse the redundant branch in read_block_lines_label that re-cleared an already-handled attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-line-numbersspec (or a newcode-window-linesattribute) as a chip beside the filename in the code-window title bar across HTML, Reveal.js, and Typst.Toggled globally via the new
lines-labeloption (defaulttrue).<details>element on HTML and Reveal.js when the newcode-window-collapseattribute is set per block, or document-wide via the newcollapseoption (true/false/open/closed).The title bar becomes the
<summary>so existing CSS continues to work.--code-window-macos-icon,--code-window-windows-icon, matching icon-width variables, and a shared icon-height variable) so users can override the macOS/Windows window-button SVGs from their own stylesheet.html,logging,metadata,pandoc-helpers,string) with the canonical versions increating-quarto-extension/assets/modules.example.qmdcover the new chip, collapsible windows, and CSS-variable overrides.