MC 26.1 (beta): add 26.1.2 NeoForge target - #20
Merged
Conversation
26.1 is the released MC line (NeoForge 26.1.2.86 is non-beta), MCEF 2.2.0-26.1.1 supports it. Add the 26.1.2-neoforge target (Java 25). 26.1 keeps the pre-26.2 screen API: Minecraft.screen / setScreen (the gui.screen()/gui.setScreen() move happened in 26.2). Narrow those guards from >=26 to >=26.2-neoforge so 26.1 falls back to client.screen, same as 1.21.11. Everything else (sendSystemMessage, GuiGraphicsExtractor, MouseHandler.onButton) is identical across 26.1/26.2. CI: 26.1.2 added to the build matrix and release (beta, non-blocking). Verified in-game on a real 26.1.2 NeoForge client: WebGUI bridge ready, Chromium initialized. Stable targets + 26.2 unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 26.1.2 NeoForge target. 26.1 is the released MC line (NeoForge
26.1.2.86is non-beta; MCEF2.2.0-26.1.1supports 26.1.1/26.1.2).API delta 26.1 vs 26.2: the screen accessor moved into
Guionly in 26.2. In 26.1 it's stillMinecraft.screen/Minecraft.setScreen()(same as 1.21.11). So the screen/setScreen guards are narrowed>=26→>=26.2-neoforge(the-neoforgesuffix is required because stonecutter treats the loader tag as a semver prerelease, so26.2-neoforge < 26.2.0). Everything else —sendSystemMessage,GuiGraphicsExtractor/extractRenderState,MouseHandler.onButton(MouseButtonInfo)— is identical across 26.1 and 26.2.CI/release: 26.1.2 added to the build matrix (JDK 25) and release publish as a non-blocking beta (continue-on-error), mirroring 26.2.
Verified in-game on a real 26.1.2 NeoForge client (Prism):
NeoForge mod loading … for MC 26.1.2,WebGUI bridge ready,Chromium Embedded Framework initialized, no crash. All 5 stable targets + 26.2 unaffected (compiled).