feat: add runCommand/useRunCommand for page-triggered commands - #2
Merged
Conversation
runCommand(command) posts on the "command" channel so the mod can run it as the player. Only works from a server-declared trusted origin; dropped otherwise. useRunCommand() returns a stable callback. - add runCommand + useRunCommand + tests - bump to 1.6.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
runCommandand theuseRunCommand()hook so a page can run a Minecraft command, which the mod executes as the player.Fire-and-forget: it posts on the
commandchannel; the mod runs it only when the page is served from a server-declared trusted origin, and drops it otherwise.Changes
runCommand(command)util +useRunCommand()hook.runCommand.Pairs with the mod PR adding the
commandchannel + trusted-origin enforcement.Verification
npm run buildsucceeds; 32 tests pass.