Repository navigation
Fix launcher execution properties and prepare 0.7.1 - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep test execution properties on the actual test instead of passing them to generated launcher binaries. This fixes Bazel analysis failures for consumers using properties such as
test.no-sandbox.Prepare bashtest 0.7.1 for release, including the framework improvements already accumulated on main.
AG;DR
exec_propertiesto the existing list of test attributes excluded from generated POSIX and Windows launcher binaries. The outerbashtest_tools_testretains the original property dictionary unchanged.test.bashtest-regressionproperty: verify the declared outer test retains its exact properties and both launcher declarations omit them, then actually execute the Bash test. Existing CI runs the suite on Linux, macOS and managed Windows across Bazel 7.7.2, 8.8.2 and the pinned version, including manifest-only consumers.exec_propertiesreferenced the nonexistenttestexecution group.bazel test //...passed (19 tests passed, Windows-only runtime test skipped on macOS);pre-commit run --all-filespassed. After making the regression property portable and isolating its declaration fixture, the focused test, complete external consumer script, and complete tools consumer script passed locally; changed-file hooks passed. The complete current-head CI run 41211998568 passed: all nine Linux/macOS/Windows cells across Bazel 7.7.2, 8.8.2 and pinned, plus pre-commit, release-site verification and the final gate.test.no-sandboxconsumer property and passed root-workspace default and manifest modes, but exposed a separate native Bazel failure in external manifest-only unsandboxed execution:test-setup.shcould not locate its test binary. That failure reproduced locally before entering the bashtest launcher. The committed regression uses a neutral test-execution-group property to verify this fix across all supported platforms/modes without expanding its scope into Bazel test-launcher behavior.