Closed
Conversation
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
May 8, 2025
* Bumped yauzl 2.10.0 -> 3.2.0 as thejoshwolfe/yauzl#114 is fixed in v3 and yauzl does not depend on fd-slicer any more. * Vendored in extract-zip as it still depends on yauzl 2.10.0. This can be reverted if max-mapper/extract-zip#146 is merged.
hamirmahal
reviewed
Mar 13, 2026
| "debug": "^4.1.1", | ||
| "get-stream": "^5.1.0", | ||
| "yauzl": "^2.10.0" | ||
| "yauzl": "^3.2.0" |
There was a problem hiding this comment.
We should probably update it to
Suggested change
| "yauzl": "^3.2.0" | |
| "yauzl": "^3.2.1" |
There was a problem hiding this comment.
yauzl <3.2.1
Severity: moderate
yauzl contains an off-by-one error - GHSA-gmq8-994r-jv83
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yauzl released v3 more than a year ago. Among other things, it includes a fix for thejoshwolfe/yauzl#114. We bundle
extract-zipin playwright and would like to get rid of the hack related to the use of old yauzl. Bumping the dependency in extract-zip would help as current dependency chain that causes the trouble is this: