Confluence import: the pure importer package - #32
Draft
Willyfrog wants to merge 1 commit into
Draft
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pure, side-effect-free half of the importer: no HTTP, no database, no plugin API. It parses and validates an mmetl Confluence v2 bundle and produces staged data for the layers above. Because it has no I/O, it is the one layer that can be reviewed and reasoned about entirely on its own.
What's here
archive.go(secure ZIP inspection),contract.go(the v2 JSONL line contract),inspect.go(the bundle walk),classify.go,tiptap.go(canonicalization),props.go,links.go,hash.go,issue_text.go— plus their tests.What to look for
This is the layer that reads untrusted input, so it deserves security eyes:
Typedisagrees with its populated payload must be rejected, not coerced. Unknown object fields are tolerated on purpose for forward compatibility; confirm that is the only laxity.MaxSourcePropsBytesis deliberately a fraction ofPagePropsMaxBytesbecause these props end up nested inside the page's ownProps. Check the arithmetic leaves real headroom.Verification
go build ./...,go vet ./...clean.server/importersuite green.