Skip to content

Split out tables to a global css and fix top border on the table design#3327

Merged
MTRNord merged 1 commit intomainfrom
MTRNord/global-tables
Apr 9, 2026
Merged

Split out tables to a global css and fix top border on the table design#3327
MTRNord merged 1 commit intomainfrom
MTRNord/global-tables

Conversation

@MTRNord
Copy link
Copy Markdown
Contributor

@MTRNord MTRNord commented Apr 2, 2026

Description

Makes the table css apply globally instead of just the blog. It also fixes the border-top that went missing at some point.

Related issues

N/A anymore

Role

Website & Content WG

Timeline

whenever

Signoff

See commits

Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
@MTRNord MTRNord added bug Something is broken. aesthetic Visual inconsistencies or improvements labels Apr 2, 2026
@MTRNord MTRNord requested a review from a team as a code owner April 2, 2026 14:33
Copy link
Copy Markdown
Contributor

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good for the two blog pages using tables and /branding

@weeman1337 weeman1337 self-requested a review April 2, 2026 15:37
Copy link
Copy Markdown
Contributor

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't see how this fixes the issue?

image

@MTRNord
Copy link
Copy Markdown
Contributor Author

MTRNord commented Apr 3, 2026

Sorry, I don't see how this fixes the issue?
image

Oo

Thats... interesting because thats not how firefox responsive did behave for me on it. Apart from super small screensizes this did work when testing :/

Can try to improve this though. But either way I think its a good idea to make use of the uniform design globally.

@weeman1337
Copy link
Copy Markdown
Contributor

Can we remove „Fixes https://github.com/matrix-org/matrix.org/issues/3326“ and get this in? Why not have global table styles. We can work on the responsive part later?

@HarHarLinks
Copy link
Copy Markdown
Contributor

Can we remove „Fixes https://github.com/matrix-org/matrix.org/issues/3326“ and get this in? Why not have global table styles. We can work on the responsive part later?

Yep this would work for me.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 7, 2026

Deploying matrix-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ccca81
Status: ✅  Deploy successful!
Preview URL: https://47e5897f.matrix-website.pages.dev
Branch Preview URL: https://mtrnord-global-tables.matrix-website.pages.dev

View logs

@MTRNord
Copy link
Copy Markdown
Contributor Author

MTRNord commented Apr 8, 2026

Can we remove „Fixes https://github.com/matrix-org/matrix.org/issues/3326“ and get this in? Why not have global table styles. We can work on the responsive part later?

Yep this would work for me.

@HarHarLinks removed it from the description. Feel free to consider this unblocked then

@MTRNord MTRNord requested a review from HarHarLinks April 8, 2026 15:36
@MTRNord MTRNord merged commit 2d34da5 into main Apr 9, 2026
7 checks passed
@MTRNord MTRNord deleted the MTRNord/global-tables branch April 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aesthetic Visual inconsistencies or improvements bug Something is broken.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants