Bump uniffi-bindgen - #275
Open
poljar wants to merge 2 commits into
Open
Conversation
|
Contributor
Author
You sound like you knew it would fail 🥲 |
The format slightly changed, we now have to define our module path in the default section.
richvdh
reviewed
Sep 1, 2026
|
|
||
| # Install the uniffi-bindgen-go command line utility, necessary to build the bindings. | ||
| install-uniffi-bindgen: | ||
| cargo install uniffi-bindgen-go --tag {{ UNIFFI_GO_VERSION }} --git https://github.com/NordSecurity/uniffi-bindgen-go |
Member
There was a problem hiding this comment.
let's remove the UNIFFI_GO_VERSION var at the top, if we're not going to use it?
Might also be worth calling out the need for the dev version in the readme too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if NordSecurity/uniffi-bindgen-go#98 and uniffi 0.32.0 works for us.
There's a matching bump in the SDK repo at: matrix-org/matrix-rust-sdk#6947