Repository navigation
Index ATR prices by position for point-and-figure box sizes - #704
Open
xvruipeng-cyber wants to merge 1 commit into
Open
xvruipeng-cyber wants to merge 1 commit into
xvruipeng-cyber wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #686.
_calculate_atrdocuments list inputs and indexes them by position. Point & Figure passesdf.High,df.Low, anddf.Close, which are Series on aDatetimeIndex. On pandas 2 that integer lookup warned and fell back to position. On pandas 3 it raisesKeyError, sobox_size='atr'cannot build a chart. Renko already passes arrays, and integer indexing on an array is positional.The function now converts highs, lows, and closes with
numpy.asarraybefore the loop, so both callers use positions and keep the same true-range values.Test plan
pytest -o addopts= tests/test_atr.py: a 2-bar ATR on a datetime-indexed Series, a ndarray, and a list all return 3box_size='atr'on pandas 3