Recover ChangeLogBlocks from ChangeLogFile#10
Merged
tonyastolfi merged 24 commits intomathworks:mainfrom Mar 17, 2026
Merged
Conversation
added 7 commits
January 16, 2026 15:09
gabrielbornstein
commented
Feb 5, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 18, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Feb 19, 2026
tonyastolfi
reviewed
Mar 3, 2026
tonyastolfi
reviewed
Mar 3, 2026
tonyastolfi
reviewed
Mar 10, 2026
tonyastolfi
reviewed
Mar 10, 2026
tonyastolfi
reviewed
Mar 10, 2026
tonyastolfi
reviewed
Mar 10, 2026
tonyastolfi
reviewed
Mar 10, 2026
tonyastolfi
reviewed
Mar 11, 2026
| return this->buffer_.size(); | ||
| } | ||
|
|
||
| MutableBuffer buffer() |
Collaborator
Author
There was a problem hiding this comment.
Something weird is going on... maybe a UI issue? I can see the const added on the most recent commit here:
https://github.com/gabrielbornstein/turtle_kv/blob/gbornste/recover-memtable/src/turtle_kv/change_log_block.hpp
As well as in my branch, but it isn't showing up in the MR. Maybe it'll get fixed with my next commit? Either way, it should actually be there
Collaborator
There was a problem hiding this comment.
Problem solved; the const should be after the param list.
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 11, 2026
tonyastolfi
reviewed
Mar 16, 2026
tonyastolfi
reviewed
Mar 16, 2026
tonyastolfi
reviewed
Mar 16, 2026
tonyastolfi
reviewed
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes new functions to recover and initialize ChangeLogBlocks from the ChangeLogFile after the KVStore has been shutdown, and the ChangeLogFile has been written to disk.
Also includes refactoring for the KVStore test suite, so that there is less redundant code, and future tests will be more portable and easier to write.
Note: Some investigation is needed. ChangeLogBlock::verify() is failing, however, we are reading correct and consistent ChangeLogBlock data.