Repository navigation
Pin core v1.57.1: a model of one set takes edits of its set - #213
Merged
Merged
Conversation
Most models have one set, which MATLAB's JSON index lists inline. Its first paint is to offer the gallery's Configurations tiles, its set's name is editable, and a set added is saved (one.slx, MATLAB's own save of a model as new_system makes it).
It edits the configuration sets of a model of one set, which 1.57.0 refused, so the Add gallery offered no Configurations tiles for most models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found trying #212 with F5: the model tab's Add gallery showed no Config Set / Config Reference tiles for most models. Core 1.57.0 refused the configuration sets of every R2026b+ model of one set (MATLAB's JSON index lists one set inline; the writer knew only the form of two or more). Core v1.57.1 (mathworks/data-explorer-core#268) fixes it, measured against MATLAB.
one.slx(MATLAB's save of a one-set model, from core's fixtures) offersaddSections, its set's name is editable, and a set added is saved. Runs on CI.The CHANGELOG's Unreleased line already covers it.