Filter any column from its header, and show the filter as chips - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Name:gain,"Data Type"=double,Value>10.:(contains),=,!=/~=,>,<,>=,<=.×.Why
Per-column filtering already existed for five of eighteen columns and nothing in
the UI said so. The popup makes it discoverable, the chips make the active filter
reviewable, and Enter makes the filter pass happen once per question instead of
once per keystroke — which matters on a 128k-row dictionary.
One parse in
src/webview/rowFilter.tsfeeds all four consumers (row filtering,<mark>highlighting, the chips, and the popup's prefill), so the surfaces cannotdisagree about what a condition means.
Behaviour change
value:"5"used to be an exact, case-sensitive match — the one exception in agrammar that is otherwise substring and case-insensitive. Quoting now only groups,
and
Value=5is how to ask for exactly 5. Noted in the README.Also fixed
In a
.prjtable,type:resolved to the dictionary'sDataTypecolumnunconditionally and matched nothing while naming a column on screen. A prefix now
resolves against the table's own columns first.