Repository navigation
Pin core v1.57.1: a model of one set takes edits of its set - #100
Merged
Merged
Conversation
Core now edits the configuration sets of a model of one set, which it refused before (its JSON index, which MATLAB writes inline for one set). So a set's row there says its Name and Description are editable, as a model's of more sets already did. That is the only change in the three goldens it touches: sparse_ws.slx, mcosfix.slx, projmodel.slx.
It edits the configuration sets of a model of one set, which the goldens now hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core v1.57.1 (mathworks/data-explorer-core#268) edits the configuration sets of a model of one set, which 1.57.0 refused: MATLAB's JSON index lists one set inline, and the writer knew only the one-entry-a-line form of two or more. So the Add gallery offered no Configurations tiles for most models.
No view code changes. The three goldens of one-set models (sparse_ws.slx, mcosfix.slx, projmodel.slx) now hold a set's row with its Name and Description editable (
Name.editable,_descriptionEditable), as a model of more sets already did; nothing else in them moved. The dev pin and the README example move to core v1.57.1; the peer range stays ^1.56.0.npm run verify: 4,720 pass.