refactor(core): move the AdvancedDnD module into dockview-core#1387
Merged
Conversation
Relocate the AdvancedDnD service and its tests from dockview-modules into dockview-core, register it via allModules, and export it from the core entrypoint. Repoint the drop-guide and keyboard-docking modules, which dependOn it, to import AdvancedDnDModule from dockview-core. Public API and behaviour are unchanged: the dockview meta-package re-exports core, and DockviewComponent auto-registers AllModules. Core 1117 + modules 184 tests green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mathuo
force-pushed
the
refactor/advanced-dnd-to-core
branch
from
68b02fc to
6c363db
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Relocates the AdvancedDnD module from
dockview-modulesintodockview-core.advancedDnDService.ts(implementation) and its three test specs into core.AdvancedDnDModulevia core'sallModules.ts(so it auto-registers from core), and exportsAdvancedDnDModule/AdvancedDnDServicefrom the core entrypoint.dependsOnit — drop guide and keyboard docking — to importAdvancedDnDModulefromdockview-core.The service's contract (
IAdvancedDnDHost/IAdvancedDnDService) already lived in core'smoduleContracts.ts; only the implementation and tests needed to move.Why
AdvancedDnD's
onWill*hooks have shipped in core for years, so it belongs with the built-in core modules rather than the separately-distributed package. Moving it into core also resolves an existing coupling where core reached into the sibling package to call the service.Behaviour / API
Unchanged. The
dockviewmeta-package re-exports core (export * from 'dockview-core'), soAdvancedDnDModule/AdvancedDnDServiceremain importable fromdockview, andDockviewComponentauto-registersAllModulesexactly as before.Verification
dockview-core: 1117 tests green (incl. the relocated specs),tsc --noEmitclean, full build clean.dockview-modules: 184 tests green,tsc --noEmitclean against the rebuilt core types.🤖 Generated with Claude Code