Core compatibility with ILIAS: Add helpers for platform-specific paths and input rendering - #1843
Open
Saaweel wants to merge 9 commits into
Open
Core compatibility with ILIAS: Add helpers for platform-specific paths and input rendering#1843Saaweel wants to merge 9 commits into
Saaweel wants to merge 9 commits into
Conversation
Add recent entries to reference list
Member
|
Thanks @Saaweel that's really very helpful. We'll review these (when the holidays are over) and sort out some mechanism to implement the changes you need. Please let us know of anything similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
As part of the ongoing STACKForILIAS 11.0.0 work, this PR adds a few small extension points to STACK core that allow ILIAS to reuse the same code without carrying local copies of Moodle-specific paths and rendering details.
The changes are intentionally minimal and preserve existing Moodle behaviour:
stack_plot_url_base()andstack_cors_scripts_dir()inlocallib.php.replace_validation_tags()with an optional custom validation value.get_name()to the base input API.These changes are needed by STACKForILIAS, but are neutral for Moodle and reduce future divergence between both integrations.
Validated with PHP lint and on Moodle 5.2 using the STACK healthcheck, including CAS, cache, plots, JSXGraph and Parsons.
Kind regards,
Saúl
SURLABS