Allow entity definitions to load synchronously, and add tests for it.#1532
Open
dpvc wants to merge 1 commit into
Open
Allow entity definitions to load synchronously, and add tests for it.#1532dpvc wants to merge 1 commit into
dpvc wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1532 +/- ##
===========================================
+ Coverage 86.70% 86.72% +0.01%
===========================================
Files 340 341 +1
Lines 86264 86378 +114
Branches 3246 3247 +1
===========================================
+ Hits 74798 74913 +115
+ Misses 11466 11465 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to synchronously load entity extensions from node applications that have
asyncIsSyncronousset. This is similar to the synchronous loading of dynamic font data font. A number of new tests are added, and the current single function is broken into several pieces.It also removes a deprecated use of
RegExp.$1.