Produce message if locale isn't set when using direct access to MathJax modules.#1484
Open
dpvc wants to merge 2 commits into
Open
Produce message if locale isn't set when using direct access to MathJax modules.#1484dpvc wants to merge 2 commits into
dpvc wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an error message about not having set up localization, if that is the case. This applies only to node applications that use direct access to the MathJax modules (since the component-based apps in node or the browser will have
Locale.setLocale()performed automatically). In this PR, when a MathDocument is created, the Locale is checked and itsetLocale()has never been called, the message is generated. When we have a URL to point to, it should be added to the message.