Degrade to identity on a malformed transform substring instead of raising ValueError - #247
Open
eeshsaxena wants to merge 1 commit into
Open
Degrade to identity on a malformed transform substring instead of raising ValueError#247eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
_parse_transform_substr raised a bare ValueError when a transform substring had
non-numeric values (float('x')) or the wrong number of parentheses (the
type(...) split). parse_transform already warns and returns the identity matrix
for an unknown transform type or a wrong argument count, so handle these the
same way instead of raising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_transformalready tolerates malformed input in most places: it warns and returns the identity matrix for an unknown transform type or a wrong number of arguments. But two cases still raise a bareValueError:parse_transform('matrix(1 x 3 4 5 6)')->float('x')raises;(, e.g. a stray'matrix', so thetype, values = substr.split('(')unpack fails.I guarded both so they warn and fall back to the identity matrix, matching the existing
_check_num_parsed_values/ unknown-type behavior. Valid transforms are unchanged.Added a test with the malformed variants; it raises ValueError on master and passes with the change, and the rest of the parsing tests still pass.