Open
Conversation
Some IRC daemons such as InspIRCd return an random string after a client's CAP REQ request. This would fail to match and block SASL AUTHENTICATEs. Also the space after sasl would also block the above AUTHENTICATEs. This change: * allows for emitting that output in logs via debug in config * stops matching on said field which can be an irrelevant moving target * removes the trailing space for the mentioned sasl field Example: $ openssl s_client -connect irc.corp.com:6697 ... CAP REQ :sasl :irc.corp.com CAP 354AAUXBK ACK :sasl ^C $ openssl s_client -connect irc.corp.com:6697 ... CAP REQ :sasl :irc.corp.com CAP 354AAUXC8 ACK :sasl
3873fca to
87e783d
Compare
|
I'm not really sure that this project is being updated any more – I forked it a while back (irc-upd on npm) and recently fixed up the SASL handling to be more compliant with the IRCv3 spec (including a change similar to this one – it requires only that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some IRC daemons such as InspIRCd return an random string after a
client's CAP REQ request. This would fail to match and block SASL
AUTHENTICATEs. Also the space after
saslwould also block the aboveAUTHENTICATEs.
This change:
target
Example InspIRCd output: