Repository navigation
perf: drop promise layers from batch and file loading - #499
Open
chrispader wants to merge 1 commit into
Open
chrispader wants to merge 1 commit into
chrispader wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
executeBatchAsync, the connection's executeBatchAsync and loadFileAsync wrapped the native promise in async functions, the same layers #496 removed from executeAsync. They now return the queued native promise directly. callNativeAsync keeps reporting a synchronous native throw as a rejected NitroSQLiteError, and executeRawAsyncNative uses it too. It lives with rejectWithNitroSQLiteError in nativePromise.ts, since neither is specific to executing queries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chrispader
force-pushed
the
async-overhead/batch-promise-layers
branch
from
November 16, 2026 16:33
7cccf3d to
b2932ce
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#496 removed the
asyncwrappers fromexecuteAsync(), butexecuteBatchAsync()andloadFileAsync()still wrapped the native promise in up to three async functions. Each layer creates a promise, and an async function that returns another promise needs two extra microtask turns to settle. Both methods now return the queued native promise directly.A new
callNativeAsync()helper still reports a synchronous native throw as a rejectedNitroSQLiteError, andexecuteRawAsyncNative()uses it too. It lives innativePromise.tswithrejectWithNitroSQLiteError(), which moves out ofexecute.ts, since neither is specific to running queries.🤖 Generated with Claude Code