Skip to content

perf: improve e2e test performance in CI#873

Open
marcodejongh wants to merge 2 commits intomainfrom
claude/improve-e2e-test-performance-65gvB
Open

perf: improve e2e test performance in CI#873
marcodejongh wants to merge 2 commits intomainfrom
claude/improve-e2e-test-performance-65gvB

Conversation

@marcodejongh
Copy link
Owner

  • Add npm dependency caching via actions/setup-node cache option
  • Add Next.js build cache (packages/web/.next/cache) to avoid full rebuilds
  • Parallelize independent build steps (shared-schema + crypto together,
    backend + web together)
  • Start backend and web servers simultaneously, wait for both at once
  • Increase Playwright workers from 2 to 4 (matches test file count)
  • Reduce retries from 2 to 1 to cut time on legitimate failures
  • Create Playwright auth setup project with storageState so login runs
    once instead of per-test in authenticated test suites
  • Extract authenticated tests into separate *.authenticated.spec.ts files
    that use pre-authenticated browser state
  • Reduce job timeout from 30 to 20 minutes

https://claude.ai/code/session_018Warj6iVNNbvvx1uKWa3E1

- Add npm dependency caching via actions/setup-node cache option
- Add Next.js build cache (packages/web/.next/cache) to avoid full rebuilds
- Parallelize independent build steps (shared-schema + crypto together,
  backend + web together)
- Start backend and web servers simultaneously, wait for both at once
- Increase Playwright workers from 2 to 4 (matches test file count)
- Reduce retries from 2 to 1 to cut time on legitimate failures
- Create Playwright auth setup project with storageState so login runs
  once instead of per-test in authenticated test suites
- Extract authenticated tests into separate *.authenticated.spec.ts files
  that use pre-authenticated browser state
- Reduce job timeout from 30 to 20 minutes

https://claude.ai/code/session_018Warj6iVNNbvvx1uKWa3E1
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Preview, Comment Feb 28, 2026 0:25am

Request Review

@claude
Copy link

claude bot commented Feb 28, 2026

Claude Review

Ready to merge - Minor issues noted below, but nothing blocking.

Minor Issues

  1. Cache key may miss dependency changes (.github/workflows/e2e-tests.yml:65-68): The Next.js cache key only hashes packages/web/**/*.ts|tsx|css but does not include package-lock.json or changes to dependencies in @boardsesh/shared-schema, @boardsesh/db, etc. This could lead to stale cache when only dependencies change. Consider adding package-lock.json and key dependency files to the hash.

  2. Redundant env var check (packages/web/e2e/help-screenshots-authenticated.authenticated.spec.ts:20-22): The test.skip(\!testEmail || \!testPassword, ...) check is redundant since auth.setup.ts already skips when these vars are missing, and the authenticated project depends on the setup project. Not harmful, but adds noise.

  3. PR description mismatch: The description says "Increase Playwright workers from 2 to 4" but playwright.config.ts shows workers remaining at 2 (with comment "CI workers: 2 keeps server load manageable"). Consider updating the PR description for accuracy.

Documentation Check

  • No documentation updates needed - this PR changes CI/test infrastructure which is not covered by the existing docs.

4 workers caused resource contention with heavy board page queries,
leading to page.goto timeouts and navigation failures. 2 workers
keeps the server responsive while the build/caching optimizations
provide the main time savings.

https://claude.ai/code/session_018Warj6iVNNbvvx1uKWa3E1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants