Skip to content

Enable swipe actions on climb list items in proposal feed#865

Open
marcodejongh wants to merge 2 commits intomainfrom
claude/enable-climb-swipe-actions-wYq4Y
Open

Enable swipe actions on climb list items in proposal feed#865
marcodejongh wants to merge 2 commits intomainfrom
claude/enable-climb-swipe-actions-wYq4Y

Conversation

@marcodejongh
Copy link
Owner

Remove the disableSwipe prop from ClimbListItem in ProposalCard so users
can swipe right to favorite and swipe left to add to queue directly from
the proposals feed.

https://claude.ai/code/session_01NmGGnHDYGNjvZ1VLSnz5Bz

Remove the disableSwipe prop from ClimbListItem in ProposalCard so users
can swipe right to favorite and swipe left to add to queue directly from
the proposals feed.

https://claude.ai/code/session_01NmGGnHDYGNjvZ1VLSnz5Bz
Wire up the onSelect handler on ClimbListItem in ProposalCard so that
double-tapping a climb preview sets it as the active climb via the queue
context's setCurrentClimb. Uses useOptionalQueueContext so it gracefully
does nothing when outside a queue provider.

https://claude.ai/code/session_01NmGGnHDYGNjvZ1VLSnz5Bz
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Building Building Feb 28, 2026 8:21am

Request Review

@claude
Copy link

claude bot commented Feb 28, 2026

Claude Review

⚠️ Needs attention - Test will fail due to removed disableSwipe prop, missing mock for new import.

Issues

  1. Failing test - packages/web/app/components/social/__tests__/proposal-card.test.tsx:145-151: Test "passes disableSwipe prop to ClimbListItem" expects disableSwipe: true but the PR removes this prop. The mock at lines 25-37 also needs updating to handle onSelect instead of disableSwipe.

  2. Missing mock - packages/web/app/components/social/__tests__/proposal-card.test.tsx: The test doesn't mock useOptionalQueueContext from @/app/components/graphql-queue, which is now imported in proposal-card.tsx. This may cause test failures.

  3. Memo comparison mismatch - packages/web/app/components/climb-card/climb-list-item.tsx:338-344: The React.memo comparison function doesn't include onSelect in its checks, so if the parent's onSelect callback changes (e.g., when queueContext changes), ClimbListItem won't re-render and will use a stale callback. Consider adding onSelect to the comparison or using useCallback with stable dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants