You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace circular swipe indicators with blue square action backgrounds
that slide in from the edges, matching the existing queue control bar
swipe experience. Uses FastForwardOutlined/FastBackwardOutlined icons
and the primary theme color for the action backgrounds.
Replace circular swipe indicators with blue square action backgrounds
that slide in from the edges, matching the existing queue control bar
swipe experience. Uses FastForwardOutlined/FastBackwardOutlined icons
and the primary theme color for the action backgrounds.
Inline styles violate project guidelines (play-view-client.tsx:188-227) - CLAUDE.md says "Try to avoid use of the style property." The swipe action backgrounds use extensive inline styles that should be moved to CSS classes.
Hardcoded color value (play-view-client.tsx:204, 228) - color: 'white' should use a design token from theme-config.ts per project guidelines.
Potential UX regression - Removing delta: 10 from swipeHandlers means swipes now trigger immediately without any dead zone, which could cause accidental navigation on slight touches.
SSR Hydration Risk (play-view-client.tsx:46-58): Direct localStorage access in useEffect can cause hydration mismatches between server and client. Consider wrapping in a check or using a library like useSyncExternalStore.
Excessive inline styles (play-view-client.tsx:203-217, 225-240, 251-255): Per CLAUDE.md guidelines, the style property should be avoided. These repeated inline styles should be moved to CSS module classes.
Missing error handling for localStorage (play-view-client.tsx:47, 64): localStorage can throw in private browsing mode or when storage quota is exceeded. Wrap in try-catch.
…tyles
- Wrap localStorage access in try-catch for private browsing compatibility
- Add isClient state to prevent SSR hydration mismatch for swipe elements
- Move static swipe action styles from inline to CSS module classes
- Remove unnecessary inline styles (padding, positioning, etc.)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace circular swipe indicators with blue square action backgrounds
that slide in from the edges, matching the existing queue control bar
swipe experience. Uses FastForwardOutlined/FastBackwardOutlined icons
and the primary theme color for the action backgrounds.