Skip to content

Conversation

@hduelme
Copy link
Contributor

@hduelme hduelme commented Dec 28, 2025

@filiphr as a follow up of #248 I disabled the coverage upload to Codecov.
Step skipped in contributors repositories https://github.com/hduelme/mapstruct-idea/actions/runs/20558714613/job/59046427179, but still run on PR https://github.com/mapstruct/mapstruct-idea/actions/runs/20558771239/job/59046546343?pr=252

The changes made in #248 on Codecov can be reverted.

@filiphr
Copy link
Member

filiphr commented Dec 28, 2025

Thanks @hduelme. I don't think that it runs on PRs now. There are only 7 checks now, vs the 8 before. The codecov check is missing

@hduelme
Copy link
Contributor Author

hduelme commented Dec 28, 2025

@filiphr filiphr merged commit 157fe25 into mapstruct:main Dec 29, 2025
7 checks passed
@filiphr
Copy link
Member

filiphr commented Dec 29, 2025

You are right @hduelme. I was looking for the check, but maybe there is anyways no check reported if there is no change. The upload is correct. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants