Reject unscoped requests to task cluster endpoint - #1284
Merged
Merged
Conversation
Previously, PUT /api/v2/taskCluster with noe challenge id or bbox would run k-means clustering over every task in the database, which would take minutes (the reverse proxy would reply with a 504 long before the query returned) and potentially spill a large amount of data to temp files on disk, which managed to cause the DB autoscaler to kick in twice recently (on Sept 25 and Sept 30).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, PUT /api/v2/taskCluster with no challenge id or bbox would run k-means clustering over every task in the database, which would take minutes (the reverse proxy would reply with a 504 long before the query returned) and potentially spill a large amount of data to temp files on disk, which managed to cause the DB autoscaler to kick in twice recently (on Sept 25 and Sept 30).