fix(ci): relax ruff rules and fix test flakes - #17
Merged
mambo-wang merged 1 commit intoAug 26, 2026
Conversation
- ruff: ignore cosmetic E701/E702/E741/E731/E501, per-file F401 for tests - ci: add git config for deterministic user_id; remove ruff format check for cleaner logs - ci: bump astral-sh/setup-uv v6->v7 to fix Node.js 20 deprecation warnings - cache/wiki_search: fix import style (E401) and unused imports - tests: fix missing store arg and mock git fallback
LiberiFatali
force-pushed
the
fix/ci-upstream-32919308882
branch
from
August 26, 2026 02:56
5262bbc to
3df613c
Compare
3 tasks
mambo-wang
added a commit
that referenced
this pull request
Aug 26, 2026
…ow-up to #17) PR #17 relaxed the ruff config broadly to unblock CI. This narrows the relaxation to what the codebase actually needs: - pyproject: ignore only E701/E702 (250+ legacy one-line multiple statements, cosmetic); remove E741/E731/E501 from ignore (E501 was never active under the pinned select anyway) and drop the tests/* F401 per-file exemption - fix all 22 E741 sites (rename ambiguous `l` to line/link/node) - fix the single E731 site (lambda -> def in test_existence_filter) - clean 24 unused imports across codewiki/ and tests/ (F401) - drop 2 unused local variables (F841) in analysis.py / smoke_test_mcp.py Full suite: 430 passed, 2 skipped. Touched files are clean under the tightened config; remaining repo-wide violations (E701/E702/E402/etc.) are untouched legacy counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
develop@73b5870CI failing bothTestandLint(e.g. run32878180052fix(review_changes): ...— Test:failure Lint:failure). Last 5+ pushes ondevelopred due to:ruff checkflagging cosmeticE701/E702/E741/E731/E501andF401intests/*ruff format --checkdrift blocking linttests/test_review_changes.pymissingstorearg (handle_analyze_repo(..., store)) andtest_team_telemetry.test_git_config_fallbacknon-deterministicuser_idin CI (no git config)Fork commit
dbe6fa6(run32923238422) was green (Test:successLint:success). Cherry-picked as5262bbcwith one change per review: removeRuff format checkentirely for cleaner logs (nocontinue-on-errorwarning).Changes vs
mambo-wang:develop:pyproject.toml:ignore = ["E741","E731","E701","E702","E501"]+[tool.ruff.lint.per-file-ignores] "tests/*" = ["F401"]codewiki/mcp/cache.py,wiki_search.py: splitimportlines, drop unused imports (_STOPWORDS,load_usage_ranking_config, etc.) — fixesE401/F401.github/workflows/ci.yml: addgit config --global user.email/namefor deterministic tests; removeRuff format check changed filesstep (keep onlyruff check)tests/test_review_changes.py:handle_analyze_repo({"repo_path": REPO_PATH}, store)tests/test_team_telemetry.py: mock_git_user_email/_git_user_name, clear_GIT_USER_*_CACHEBased on LiberiFatali@dbe6fa6 (amended to drop format check).
Target: make
developCI green and lint non-noisy.