Fixed fx for manual progressive slideshows#560
Open
Thimp wants to merge 1 commit intomalsup:masterfrom
Open
Conversation
The Fx of my manual progressive slideshow wasn't working the way I expected. The fx started on the old slide (slide to left or fade-out) and then briefly the background was visible and then the fx started on the new slide. The slides weren't synchronized anymore. A small timeout fixed this issue. You can see the bug in the demo of the progressive loading manual slide: http://jquery.malsup.com/cycle2/demo/progressive.php#manual
|
Not sure if this is the best solution, but it works :) should at least be merged |
|
I was having this same issue with progressively loading slides via javascript, using the fade transition. This timeout fixed it for me as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fx of my manual progressive slideshow wasn't working the way I expected. The fx started on the old slide (slide to left or fade-out) and then briefly the background was visible and then the fx started on the new slide. The slides weren't synchronized anymore. A small timeout fixed this issue.
You can see the bug in the demo of the progressive loading manual slide:
http://jquery.malsup.com/cycle2/demo/progressive.php#manual