Add feature to allow progressive and pager to work together

[elijahmanor]

• If pager active, then add placeholder progressive slides
• Intercept render of progressive slide and swap in fully rendered slide before show
• Add unit tests

bower install
grunt connect
open http://localhost:9001/spec/index.html

[malsup]

Thanks for the PR Elijah! I haven't had enough time to dig into it completely but in my quick testing I found that my demo progressive page no longer worked when I merged this change. I need to carve out some time to see if it's something I merged prior or something in that page or something else. Just wanted to make this note so you don't think I'm ignoring you! :-)

[elijahmanor]

Do you have your demos somewhere for me to test? Which one in particular was failing for you?

[mgbowman]

Well I just tried a quick and dirty test pulling the src/jquery.cycle2.progressive.js into my app and rebuilding my JS with Grunt and the pager shows up with the correct number of bullets, but the progressive slides are just blank. If I can find some time, I will look through the source to try and debug further but there's definitely a problem with the PR :(

It's a bummer because I could use this exact feature in my current project.

[jasonday]

Any further work on this?

I see the pager showing the correct number of slides, however for any slides that are not the first, the slideshow doubles in height leaving a large white space at the top.

It appears that the issue is with the ".slide-sentinel".

There's something odd happening in this bit of code:
When a new slide comes in, the sentinel is maintaining a white space because of of the mix of position:static and visibility: hidden.

clone.css({
        position: 'static',
        visibility: 'hidden',
        display: 'block'
    }).prependTo( opts.container ).addClass('cycle-sentinel cycle-slide').removeClass('cycle-slide-active');
    clone.find( '*' ).css( 'visibility', 'hidden' );

In looking further, the issue is centered around horizontal scroll plugin - data-cycle-fx="scrollHorz" and the progressive plugin changes you have made.