Update scrollVert tu use scrollUp or scrollDown#334
Open
Joan wants to merge 1 commit intomalsup:masterfrom
Joan:master
Open
Update scrollVert tu use scrollUp or scrollDown#334Joan wants to merge 1 commit intomalsup:masterfrom Joan:master
Joan wants to merge 1 commit intomalsup:masterfrom
Joan:master
Conversation
scrollVert exists as a duplicate of scrollDown.
Owner
|
I don't understand to reason for this patch. |
Author
|
It is simply a support for both up and down vertical transiton ;) |
Owner
|
scrollVert already supports up and down transitions, that's what the fwd flag is controlling. |
Author
|
Well, I tought this was all reversing, I'll check this out. Thanks for your availavility! |
|
Hey Malsup, how do i use that forward flag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollVert exists as a duplicate of scrollDown.