Allow automatic swapping in of img src from data-src when needed.#329
Open
IDisposable wants to merge 1 commit intomalsup:masterfrom
Open
Allow automatic swapping in of img src from data-src when needed.#329IDisposable wants to merge 1 commit intomalsup:masterfrom
IDisposable wants to merge 1 commit intomalsup:masterfrom
Conversation
To allow lazy-loading of any image, add an API method swapInDataSrc that will copy the value from img-tag attribute data-src into src. This allows using a tiny placeholder image in the src, while still allowing preloading of the next image for easy transitions. Note that this is convention-driven to expect markup like <img src="placeholder.jpg" data-src="realimage.png" />. Any later DOM manipulation will work _just fine_ because we pull the data-src attribute (and delete it) once. We could add the ability to specify the swapping attributes and such, but meh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow lazy-loading of any image, add an API method swapInDataSrc that will copy the value from img-tag attribute data-src into src. This allows using a tiny placeholder image in the src, while still allowing preloading of the next image for easy transitions. Note that this is convention-driven to expect markup like <img src="placeholder.jpg" data-src="realimage.png" />. Any later DOM manipulation will work just fine because we pull the data-src attribute (and delete it) once. We could add the ability to specify the swapping attributes and such, but meh.