e2e: tolerate multiple tunnel statuses in all-devices unicast QA test#3976
Open
thijsvanemmerik wants to merge 1 commit into
Open
e2e: tolerate multiple tunnel statuses in all-devices unicast QA test#3976thijsvanemmerik wants to merge 1 commit into
thijsvanemmerik wants to merge 1 commit into
Conversation
thijsvanemmerik
force-pushed
the
e2e-alldevices-tolerate-multicast-tunnel
branch
from
bce0e73 to
b2b45d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestQA_AllDevices_UnicastConnectivitycalled the deprecatedGetUserStatus, which returns an error when a host reports more than one tunnel status. A host that holds both an IBRL and a Multicast tunnel therefore errored and was dropped from the batch, and a batch with fewer than two connected clients times out.GetUserStatuses+FindIBRLStatus, which select the IBRL status (and return the sole status on single-tunnel hosts). A host with a lingering Multicast tunnel is now kept via its IBRL status; a host with no IBRL status is excluded from routing.Testing Verification
TestFindIBRLStatuscovering: single status returned as-is, IBRL selected when an IBRL and a Multicast status are both present (includingIBRLWithAllocatedIP), and nil when no IBRL status exists.go test ./e2e/internal/qa/ -run TestFindIBRLStatuspasses;go vet -tags qa ./e2e/...clean.