Repository navigation
fix: detect raw end tags and comments inside code blocks - #45
Open
Aaqibhafeezkhan wants to merge 1 commit into
Open
Aaqibhafeezkhan wants to merge 1 commit into
Aaqibhafeezkhan wants to merge 1 commit into
Conversation
Aaqibhafeezkhan
commented
Nov 16, 2026
Aaqibhafeezkhan
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review:
- Extended
code-escapedto detect unexpected HTML comments. - Added detection for malformed closing tags using parse5 parser errors and source offsets.
- Preserved the existing allowed syntax-highlight spans.
- Added regression fixtures for the reported edge cases.
- Updated validation documentation.
- Verify the generated validator bundle is updated.
- Run the build, type checks, and complete test suite.
Aaqibhafeezkhan
force-pushed
the
fix/issue-40-code-block-raw-markup
branch
from
November 16, 2026 06:01
bd94cb0 to
b876470
Compare
Owner
|
Hey @Aaqibhafeezkhan , Thank you for raising the PR. I will review and get back to you. |
Aaqibhafeezkhan
force-pushed
the
fix/issue-40-code-block-raw-markup
branch
from
November 16, 2026 23:27
b876470 to
d89862e
Compare
Signed-off-by: Aaqibhafeez Khan <githubaaqibhafeezkhan@gmail.com>
Aaqibhafeezkhan
force-pushed
the
fix/issue-40-code-block-raw-markup
branch
from
November 20, 2026 00:34
d89862e to
4101b69
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
code-escapedvalidation check so it catches raw HTML comments and malformed closing tags inside<pre>and<code>blocks.Previously, the validator detected unexpected HTML elements but could miss raw closing tags and HTML comments.
Changes
.del,.add, and.hispans.</pre>termination with injected markup.Testing
tests/validate-output/fail/code-escaped/.Closes #40