Skip to content

Add As1 support#1257

Open
tristanpwdennis wants to merge 6 commits intomalariagen:masterfrom
tristanpwdennis:add-As1
Open

Add As1 support#1257
tristanpwdennis wants to merge 6 commits intomalariagen:masterfrom
tristanpwdennis:add-As1

Conversation

@tristanpwdennis
Copy link
Copy Markdown
Collaborator

See #706

@tristanpwdennis
Copy link
Copy Markdown
Collaborator Author

TODO: stage and release data, then write tests

@adilraza99
Copy link
Copy Markdown
Contributor

Hi @tristanpwdennis, the As1 integration seems to follow the existing patterns well.

While going through tests/anoph/test_snp_data.py, I noticed that the amin1 import and its amin1_sim_api fixture appear to have been replaced by the As1 equivalents rather than added alongside them. The case_amin1_sim test still references amin1_sim_api, so I was wondering if this might be contributing to one of the CI failures.

In some of the other test files, it looks like the existing species fixtures are kept and new ones are added alongside them. Would that be the intended approach here as well?

@tristanpwdennis
Copy link
Copy Markdown
Collaborator Author

Good spot - thanks @adilraza99, I will fix these

@tristanpwdennis
Copy link
Copy Markdown
Collaborator Author

@jonbrenas @ahernank - testing has hit an issue. As discussed we didn't generate contamination QC data for the samples. The tests fail as they are expecting comtam_pc and contam_llc columns.

Rather than restructure the tests, I've added dummy data to the columns in the fixture. My rationale for this is that in the future, we will be able to include contamination data in sample set QC. Let me know if there are any issues around this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants