Conversation
|
TODO: stage and release data, then write tests |
|
Hi @tristanpwdennis, the As1 integration seems to follow the existing patterns well. While going through In some of the other test files, it looks like the existing species fixtures are kept and new ones are added alongside them. Would that be the intended approach here as well? |
|
Good spot - thanks @adilraza99, I will fix these |
|
@jonbrenas @ahernank - testing has hit an issue. As discussed we didn't generate contamination QC data for the samples. The tests fail as they are expecting comtam_pc and contam_llc columns. Rather than restructure the tests, I've added dummy data to the columns in the fixture. My rationale for this is that in the future, we will be able to include contamination data in sample set QC. Let me know if there are any issues around this. |
See #706