fix: expose completed_at filter in frontend issue views - #9538
Open
okxint wants to merge 1 commit into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe PR adds the optional ChangesCompleted-at issue filtering
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
actor User
participant FilterSelection
participant FilterCompletedAt
participant DateFilterModal
User->>FilterSelection: Open completed_at filter
FilterSelection->>FilterCompletedAt: Render filter
User->>FilterCompletedAt: Select date option
FilterCompletedAt->>FilterSelection: Update completed_at values
User->>FilterCompletedAt: Select custom date
FilterCompletedAt->>DateFilterModal: Open modal
DateFilterModal->>FilterCompletedAt: Return selected date
FilterCompletedAt->>FilterSelection: Update completed_at values
Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The backend API (
plane/utils/issue_filters.py) fully supports filtering issues bycompleted_at, but the frontend never exposed this filter — it was impossible to use through the UI.Three gaps kept it invisible:
IIssueFilterOptionsinpackages/types/src/view-props.d.tshad nocompleted_atfield, so it could never enter filter stateFilterCompletedAtcomponent existedISSUE_DISPLAY_FILTERS_BY_LAYOUTarrays included"completed_at", soisFilterEnabled("completed_at")always returnedfalseIf a user managed to set the filter via direct API PATCH, subsequent UI edits would silently overwrite it.
Fixes #9508
Changes
packages/types/src/view-props.d.ts— addcompleted_at?: string[] | nulltoIIssueFilterOptionsfilters/header/filters/completed-at.tsx— newFilterCompletedAtcomponent (mirrorsFilterTargetDate)filters/header/filters/index.ts— exportFilterCompletedAtfilters/header/filters/filters-selection.tsx— import and renderFilterCompletedAtwhen filter is enabledweb/core/constants/issue.ts— add"completed_at"to filter arrays forissues.list,issues.kanban,issues.spreadsheet,issues.gantt_chart, andarchived_issues.listCalendar layout is intentionally excluded — completed date as a calendar axis doesn't make semantic sense.
Screenshots
No UI screenshots (component follows the identical structure and appearance as
FilterTargetDate).Summary by CodeRabbit