fix: update Twitter icon and links to X#8790
fix: update Twitter icon and links to X#8790nielskaspers wants to merge 1 commit intomakeplane:previewfrom
Conversation
📝 WalkthroughWalkthroughThis PR updates all social media references from Twitter to X across documentation and email templates, changing the URL from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/api/templates/emails/user/email_updated.html (1)
834-842:⚠️ Potential issue | 🟠 MajorUpdate the social icon asset to X, not just the destination URL.
Line 834 correctly points to
x.com, but line 842 still usestwitter_32px.png. This leaves the outdated bird icon in emails. Update the asset reference to use an X-branded icon, or replace it with an appropriate alternative. This same mismatch appears across multiple email templates (webhook-deactivate.html, issue-updates.html, user_deactivation.html, user_activation.html, and project_invitation.html).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/api/templates/emails/user/email_updated.html` around lines 834 - 842, The email template still loads a Twitter bird image (src containing "twitter_32px.png") while the anchor href points to x.com; update the img asset to an X-branded icon (or a neutral social icon) so the image matches the destination. Replace the src value that references "twitter_32px.png" with the new X icon asset URL in email_updated.html and apply the same change to webhook-deactivate.html, issue-updates.html, user_deactivation.html, user_activation.html, and project_invitation.html so all templates use the X/neutral icon consistently.
🧹 Nitpick comments (1)
apps/api/templates/emails/user/user_activation.html (1)
976-986: Consider updating “tweet” wording to X-era terminology.Line 985 still uses “tweet.” For brand consistency, consider “post” (or “post on X”).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/api/templates/emails/user/user_activation.html` around lines 976 - 986, Update the copy that currently uses the word "tweet" to X-era terminology; locate the anchor element with title="@planepowers" (the href to https://x.com/planepowers) and change the inner text node "tweet" to "post" or "post on X" (e.g., replace the <span style="font-size: 13px">tweet</span> content) to maintain brand consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@apps/api/templates/emails/user/email_updated.html`:
- Around line 834-842: The email template still loads a Twitter bird image (src
containing "twitter_32px.png") while the anchor href points to x.com; update the
img asset to an X-branded icon (or a neutral social icon) so the image matches
the destination. Replace the src value that references "twitter_32px.png" with
the new X icon asset URL in email_updated.html and apply the same change to
webhook-deactivate.html, issue-updates.html, user_deactivation.html,
user_activation.html, and project_invitation.html so all templates use the
X/neutral icon consistently.
---
Nitpick comments:
In `@apps/api/templates/emails/user/user_activation.html`:
- Around line 976-986: Update the copy that currently uses the word "tweet" to
X-era terminology; locate the anchor element with title="@planepowers" (the href
to https://x.com/planepowers) and change the inner text node "tweet" to "post"
or "post on X" (e.g., replace the <span style="font-size: 13px">tweet</span>
content) to maintain brand consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a32668b8-cc24-4eb8-8567-2c1ec854509f
📒 Files selected for processing (7)
README.mdapps/api/templates/emails/invitations/project_invitation.htmlapps/api/templates/emails/notifications/issue-updates.htmlapps/api/templates/emails/notifications/webhook-deactivate.htmlapps/api/templates/emails/user/email_updated.htmlapps/api/templates/emails/user/user_activation.htmlapps/api/templates/emails/user/user_deactivation.html
|
@nielskaspers Can you please sign the CLA |
|
@sriramveeraghanta done! |
Summary
Updates the Twitter bird icon to the X icon and changes twitter.com links to x.com to reflect the platform's rebrand.
Issue
Fixes #8785
Changes
twitter.com/planepowersURLs tox.com/planepowersacross README and email templatesFiles changed
README.md— Updated link and labelapps/api/templates/emails/invitations/project_invitation.htmlapps/api/templates/emails/notifications/issue-updates.htmlapps/api/templates/emails/notifications/webhook-deactivate.htmlapps/api/templates/emails/user/email_updated.htmlapps/api/templates/emails/user/user_activation.htmlapps/api/templates/emails/user/user_deactivation.htmlNotes
twitter:siteandtwitter:cardmeta tags are part of the Open Graph/Twitter Card web standard and were intentionally left unchangedTwitterPicker(react-color component) is a color picker unrelated to the Twitter brandTwittericon import fromlucide-react(v0.469.0) already renders the X logopackages/utils/src/get-icon-for-link.tsalready matches bothtwitter.comandx.compatternsTesting
Summary by CodeRabbit