-
Notifications
You must be signed in to change notification settings - Fork 10
chore: opensearch embedding model dimension configurability #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akhil-vamshi-konam
wants to merge
1
commit into
master
Choose a base branch
from
chore-opensearch-embedding-dimension-config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In AWS Bedrock, do the same AWS credentials (access key, secret key, session token, region) apply for invoking both Amazon Titan embedding models and Cohere embedding models, with model ID being the main selector?💡 Result:
Yes, the same AWS credentials (access key, secret key, session token, and region) apply for invoking both Amazon Titan embedding models and Cohere embedding models in AWS Bedrock. The primary difference is the model ID specified in the InvokeModel API call: e.g., "amazon.titan-embed-text-v2:0" for Titan and "cohere.embed-english-v3" for Cohere. Both use the Bedrock Runtime service (bedrock-runtime) with standard AWS SigV4 authentication via IAM permissions like bedrock:InvokeModel.
Citations:
🏁 Script executed:
# Check if the file exists and examine lines around 236-238 and 316-318 wc -l docs/self-hosting/govern/environment-variables.mdRepository: makeplane/developer-docs
Length of output: 121
🏁 Script executed:
Repository: makeplane/developer-docs
Length of output: 1734
🏁 Script executed:
Repository: makeplane/developer-docs
Length of output: 3987
Update wording to indicate Bedrock credentials apply to all embedding models, not just Titan.
Lines 236-238 describe AWS credentials as "for Bedrock Titan embedding," but these same credentials work with any Bedrock embedding model (Titan, Cohere, etc.). The model ID is the selector, not the credentials. Change descriptions to reference "Amazon Bedrock" or "Bedrock embedding" generically to prevent confusion about model support.
Note: Lines 316-318 already use appropriate generic wording ("Amazon Bedrock integration") and do not require changes.
🤖 Prompt for AI Agents