fix: passing accessible=false to Wrapper#186
Open
yolpsoftware wants to merge 1 commit intomagicismight:masterfrom
Open
fix: passing accessible=false to Wrapper#186yolpsoftware wants to merge 1 commit intomagicismight:masterfrom
yolpsoftware wants to merge 1 commit intomagicismight:masterfrom
Conversation
Collaborator
|
i am not familar with this code, but why not simply |
Author
Fine with me. Not sure why there was a condition in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current codebase, an
accessible=falseprop won't be passed on toWrapper, because of the lineThis will always set
Wrapper.accessibleto true.This PR changes this such that
accessible=falsewill be passed on.Background: the current implementation does not seem to be testable under maestro.dev - there are other RN components that have the same problem, see for example here. One of the possible solutions is to set
accessible=falseon the container of the overlay / toast.