For clusters, allow --wait to be passed down#311
Open
emschwar wants to merge 2 commits intomacournoyer:masterfrom
Open
For clusters, allow --wait to be passed down#311emschwar wants to merge 2 commits intomacournoyer:masterfrom
emschwar wants to merge 2 commits intomacournoyer:masterfrom
Conversation
This comprises two related changes: - For individual servers, use --wait to timeout a start or stop effort. - For clusters, pass the --wait parameter down to each cluster's stop/start/restart command.
Author
|
Running specs shows this failure: I think it may be just my environment, since I'm pretty sure I didn't change anything that would have affected this test, but I'm happy to make any additional fixes if it's a real problem. |
Collaborator
|
Can you please rebase this on master? |
Author
|
Done. |
Collaborator
This is actually a bug in the MacOS network stack due to deferred resource allocation - you get a very weird error because that is actually the point where the socket is created, and the error occurs... it comes out of an "unrelated" system call. Thanks for rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comprises two related changes:
command.
(Fixes #310)