Repository navigation
Respect quoted parentheses when stripping query wrappers - #723
Open
pengpengyi92 wants to merge 1 commit into
Open
pengpengyi92 wants to merge 1 commit into
pengpengyi92 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_is_wrapped()currently counts parentheses inside quoted SQL text. For example,Parser("((UPDATE t SET a = ')'))").tablesraisesInvalidQueryDefinitionbecausethe redundant wrapper is not removed.
Count tokenizer parenthesis tokens instead of raw characters, using the existing
MySQL/T-SQL quoting markers where applicable. Leave lexically malformed input
untouched. No query execution, dialect-parser change or new dependency.
Added 31 cases covering INSERT/UPDATE/DELETE, one/two wrappers, escaped literals,
MySQL and T-SQL quoted names, and an unterminated literal. Initial regressions
failed before the production patch. Full suite: 323 passed, 100% coverage;
mypy sql_metadataandruff checkpass. Full-file formatter checks still reportpre-existing unrelated formatting differences, which are not included here.
AI-assisted with OpenAI Codex; no independent human review is claimed.