Skip to content

ci: add zizmor security scan - #402

Merged
thomson-t merged 2 commits into
mainfrom
zizmor/add-security-scan
Sep 18, 2026
Merged

thomson-t merged 2 commits into
mainfrom
zizmor/add-security-scan

Conversation

@tanmayeepemmaraju

Copy link
Copy Markdown
Contributor

Background

Add Zizmor scanning for GitHub Actions changes, matching the configuration merged in mparticle-web-sdk (mParticle/mparticle-web-sdk#1444) and mparticle-android-sdk (mParticle/mparticle-android-sdk#823).

What Has Changed

  • Add a Zizmor workflow for changes under .github/workflows/** and .github/actions/**.
  • Run it for main, development, with manual execution available.
  • Pin checkout and Zizmor actions to reviewed commit SHAs.
  • Deny permissions by default and grant only contents: read and actions: read to the scan job.
  • Preserve the Rokt SDK rollout behavior with continue-on-error: true, so findings appear as annotations without blocking unrelated work.

Validation

  • Workflow parsed as YAML and audited with zizmor 1.23.1: the new file reports no findings of its own.
  • Formatting matches Prettier defaults, so it passes Trunk in repos that run it.

Screenshots/Video

  • N/A

Checklist

  • Self-review completed
  • Tests added or updated
  • Tested locally

🤖 Generated with Claude Code

Adds GitHub Actions security scanning in advisory mode, matching the
configuration merged in mparticle-web-sdk#1444.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@tanmayeepemmaraju
tanmayeepemmaraju requested a review from a team as a code owner September 18, 2026 18:18
@cursor

cursor Bot commented Sep 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
CI workflow and linter configuration changes with no impact on runtime code or production dependencies.

Overview
Adds a new GitHub Actions workflow running Zizmor security scans on workflow and action file changes. The job runs in an advisory mode with continue-on-error: true and pinned action SHAs to report annotations on PRs without blocking workflows.

Additionally upgrades actionlint to 1.7.7 in .trunk/trunk.yaml.

Reviewed by Cursor Bugbot for commit 1366681. Bugbot is set up for automated code reviews on this repo. Configure here.

1.6.9 predates the ubuntu-24.04 runner label and rejects an empty
permissions block, both of which the zizmor scan workflow uses. Matches
the pin already used in mparticle-android-sdk, mparticle-apple-sdk and
mparticle-maui-sdk.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@thomson-t
thomson-t merged commit 1c1d49a into main Sep 18, 2026
12 checks passed
@thomson-t
thomson-t deleted the zizmor/add-security-scan branch September 18, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants