Skip to content

ci: declare accepted secrets on dependabot rebase workflow - #102

Closed
nickolas-dimitrakas wants to merge 1 commit into
mainfrom
ci/declare-rebase-workflow-secrets
Closed

nickolas-dimitrakas wants to merge 1 commit into
mainfrom
ci/declare-rebase-workflow-secrets

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Background

  • Callers of this reusable workflow currently have to use secrets: inherit to run it, since it doesn't declare which secrets it accepts.

What Has Changed

  • Declares MP_SEMANTIC_RELEASE_BOT, GPG_PRIVATE_KEY, and GPG_PASSPHRASE under on.workflow_call.secrets, matching what the job already references. This lets callers pass only those specific secrets explicitly instead of inheriting their whole secret set.

Checklist

  • I have performed a self-review of my own code.
  • I have tested this locally (workflow YAML validated; no behavior change for existing callers using secrets: inherit).

🤖 Generated with Claude Code

Declares the specific secrets this reusable workflow needs under
on.workflow_call.secrets, so callers can pass them explicitly instead
of using secrets: inherit.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@cursor

cursor Bot commented Sep 17, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Low risk CI configuration update with no logic changes to the underlying workflow jobs.

Overview
Explicitly declares the required secrets (MP_SEMANTIC_RELEASE_BOT, GPG_PRIVATE_KEY, and GPG_PASSPHRASE) on the workflow_call trigger in dependabot-rebase-development.yml. This allows calling workflows to pass specific secrets explicitly instead of relying on secrets: inherit.

Reviewed by Cursor Bugbot for commit 811e5da. Bugbot is set up for automated code reviews on this repo. Configure here.

nickolas-dimitrakas added a commit to mParticle/mparticle-android-sdk that referenced this pull request Sep 17, 2026
* ci: scope dependabot rebase workflow secrets

Replaces secrets: inherit with an explicit mapping of only the
secrets the rebase workflow actually uses, so the release signing and
publish credentials this repo carries are no longer part of what gets
passed along.

Depends on mParticle/mparticle-workflows#102 declaring these secrets
as accepted workflow_call inputs.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* docs: link CHANGELOG entry to PR #818

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* ci: remove unused dependabot rebase workflow

This workflow only ever ran against the stale development branch
(AGENTS.md already flags that branch as unused) and forwarded this
repo's full release secret set to an external reusable workflow to do
it. Nothing depends on it, so remove it instead of narrowing what it
forwards.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* revert: drop manual CHANGELOG entry

CHANGELOG entries are generated automatically; don't hand-add them.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Signed-off-by: Nickolas Dimitrakas <nickolas.dimitrakas@rokt.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Sep 17, 2026
@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor Author

Closing — the only caller of this workflow (mparticle-android-sdk's dependabot-rebase-branch.yml) is being removed instead of updated to use explicit secrets, so this change is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant